Small improvements to check runs #706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dasJ maybe you can have a look at this one? |
With long status entries with many packages, the system is cut off. Since the system is fixed length, it makes more sense to put it at the front. This allows to easily identify the relevant checks.
Everything containing a slash is not a package anyway and just creates noise in the UI.
Contributor
Author
|
One slight annoyance with the change: Previously all 4 ofborg jobs would appear next to each other, because they all start with the attrpath. After this change, they would be separate, because two start with aarch64 and two start with x86_64 - thus appearing at opposite ends of the check list. I added the shortest possible common prefix to all of them: A |
Contributor
Author
|
@Conni2461 could you look at this, too? |
|
Good |
wolfgangwalther
requested review from
Conni2461
and removed request for
Conni2461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With long status entries with many packages, the system is cut off. Since the system is fixed length, it makes more sense to put it at the front. This allows to easily identify the relevant checks.
Also avoid posting a status check for everything with "/" in the prefix, because that's not a package to build anyway.
Resolves #283